Skip to content

Update tutorial to link with setting up commodore alias#2

Merged
ccremer merged 3 commits intomasterfrom
ssh-agent
Oct 23, 2020
Merged

Update tutorial to link with setting up commodore alias#2
ccremer merged 3 commits intomasterfrom
ssh-agent

Conversation

@ccremer
Copy link
Copy Markdown
Contributor

@ccremer ccremer commented Oct 22, 2020

Remove the alias defined here, which was not the same as described in https://docs.syn.tools/commodore/running-commodore.html

@ccremer ccremer requested review from akosma and corvus-ch October 22, 2020 13:15
@corvus-ch
Copy link
Copy Markdown
Contributor

Sadly this does not work. See https://syn.tools/commodore/running-commodore.html.

@ccremer
Copy link
Copy Markdown
Contributor Author

ccremer commented Oct 22, 2020

ah thanks, didn't see that one.
Also, at least known_hosts has also to be there, as I've found out :)

Should we rather link to this explanation in the tutorial than having to maintain another version of the command alias?

@corvus-ch
Copy link
Copy Markdown
Contributor

Yes, Running Commodore was written to tackle the issue of different and sometimes wrong examples being spread all over the place.

I have updated the example for macOS (commodore/pull/228). Meanwhile I have found halve of a solution.

Removes the need to maintain another version of the commodore alias, which might get outdated.
@ccremer ccremer changed the title Forward SSH agent instead of .ssh dir Update tutorial to link with setting up commodore alias Oct 22, 2020
Copy link
Copy Markdown
Contributor

@corvus-ch corvus-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please note that our style guide states to have only one sentence per line (https://syn.tools/syn/references/style-guide.html#_asciidoc_style).

@ccremer
Copy link
Copy Markdown
Contributor Author

ccremer commented Oct 23, 2020

Hm, the whole tutorial does not adhere to the style guide. Only every paragraph is in its own line, but not sentences. I think I'll stick to the current one for consistency reasons, otherwise I'd have to touch every single paragraph.

@corvus-ch
Copy link
Copy Markdown
Contributor

I mentioned the style guide FYI. Reformatting everything is definitely not what I ask for. I would suggest to do this gradually when touching things anyway. Feel free to leave it as it is for now.

@ccremer ccremer merged commit d398771 into master Oct 23, 2020
@ccremer ccremer deleted the ssh-agent branch October 23, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants